Skip to content

Comments

[CUDA][HIP] Always wait on interop events#1753

Merged
kbenzie merged 1 commit intooneapi-src:mainfrom
hdelan:fix-interop-event-bug
Jun 20, 2024
Merged

[CUDA][HIP] Always wait on interop events#1753
kbenzie merged 1 commit intooneapi-src:mainfrom
hdelan:fix-interop-event-bug

Conversation

@hdelan
Copy link
Contributor

@hdelan hdelan commented Jun 13, 2024

We can't make assumptions about interop events being on the same stream as other interop events, since in UR we don't track the streams that native events are recorded on.

@hdelan hdelan requested a review from a team as a code owner June 13, 2024 10:15
@hdelan hdelan requested a review from mmoadeli June 13, 2024 10:15
@hdelan hdelan force-pushed the fix-interop-event-bug branch from 9c9fbc1 to 04be86d Compare June 13, 2024 10:18
@hdelan hdelan requested a review from a team as a code owner June 13, 2024 10:18
@github-actions github-actions bot added cuda CUDA adapter specific issues hip HIP adapter specific issues labels Jun 13, 2024
We can't make assumptions about interop events being on the same stream
as other interop events, since in UR we don't track the streams that
native events are recorded on.
@hdelan
Copy link
Contributor Author

hdelan commented Jun 18, 2024

Friendly ping @mmoadeli

Copy link
Contributor

@mmoadeli mmoadeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdelan hdelan added the ready to merge Added to PR's which are ready to merge label Jun 19, 2024
@kbenzie kbenzie merged commit 2c1180f into oneapi-src:main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda CUDA adapter specific issues hip HIP adapter specific issues ready to merge Added to PR's which are ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants